Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #379

Closed
wants to merge 1 commit into from
Closed

Update .gitattributes #379

wants to merge 1 commit into from

Conversation

voku
Copy link
Contributor

@voku voku commented Jul 4, 2022

Do not copy the test directory into the project, if we install it via composer.

Do not copy the test directory into the project, if we install it via composer.
@williamdes williamdes self-assigned this Jul 4, 2022
@williamdes
Copy link
Member

I can not approve this because Debian uses the tests/ folder to run autopkg tests: https://salsa.debian.org/phpmyadmin-team/sql-parser/-/blob/debian/latest/debian/tests/phpunit
Output: https://salsa.debian.org/phpmyadmin-team/sql-parser/-/jobs/2353133

@voku
Copy link
Contributor Author

voku commented Jul 4, 2022

@williamdes Understand. Do you think we could use the "exclude"-setting in the composer.json here? 🤔

e.g.:

{
    "archive": {
        "exclude": ["/tests"]
    }
}

https://getcomposer.org/doc/04-schema.md#archive

@williamdes
Copy link
Member

williamdes commented Jul 4, 2022

@williamdes Understand. Do you think we could use the "exclude"-setting in the composer.json here? thinking

Does it really work ?
Answer: yes
I accept to add this, can you edit your PR ?
Answer: Done in a201314

@williamdes
Copy link
Member

This was released right now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants