renameNx delivers false on success

[tompro]

If I use renameNx and rename a key to a key that is currently not existing the operation is performed well on Redis server. Nevertheless I get false as result from phpredis.

The follwing test fails:

$redis->set('oldkey', 'value');
$this->assertTrue(
    $redis->renameNx('oldkey', 'newkey')
);

[nicolasff]

Hello,

Thanks for this report. I'll have a look tomorrow morning and integrate your test.

[nicolasff]

Hello,

Thanks for this report. I'll have a look tomorrow morning and integrate your test.

[tompro]

Cool. Thanks for this fast reply.

[tompro]

Cool. Thanks for this fast reply.

[nicolasff]

Hello again,

It seems that the either the return value of RENAMENX has changed in Redis itself, or this bug has been here for a long time. I have fixed this issue and added a unit test.

Could you please confirm that it works as expected?

[nicolasff]

Hello again,

It seems that the either the return value of RENAMENX has changed in Redis itself, or this bug has been here for a long time. I have fixed this issue and added a unit test.

Could you please confirm that it works as expected?

[tompro]

Works like a charm. All green :) . During the next weeks I am going to cover most phpredis functions with tests as I am currently building a higher level library. I'll let you know when I encounter something else. I hope this is not very anoying for you :) .

[tompro]

Works like a charm. All green :) . During the next weeks I am going to cover most phpredis functions with tests as I am currently building a higher level library. I'll let you know when I encounter something else. I hope this is not very anoying for you :) .

[nicolasff]

Not at all, thanks for reporting this. The more I can fix, the better it will be :-)

[nicolasff]

Not at all, thanks for reporting this. The more I can fix, the better it will be :-)

[fotografi]

No description provided.

[fotografi]

No description provided.