set() fails if 3rd param is null

[nfrm]

This bug seems to have been introduced with 2.2.4

<?php

    $redis = new redis;
    $redis->connect('127.0.0.1');

    $redis->del("test");

    echo $redis->exists("test") ? 'EXISTS' : 'DOES NOT EXIST';
    echo "\n";

    $redis->set("test", "hello", null);

    echo $redis->exists("test") ? 'EXISTS' : 'DOES NOT EXIST';
    echo "\n";

    $redis->set("test", "hello");

    echo $redis->exists("test") ? 'EXISTS' : 'DOES NOT EXIST';
    echo "\n";

Result:

DOES NOT EXIST
DOES NOT EXIST
EXISTS

When testing with 2.2.3, the results are:

DOES NOT EXIST
EXISTS
EXISTS

I'm guessing it's because of this:

https://github.com/nicolasff/phpredis/blob/2.2.4/redis.c#L839-L841

I'm not overly adept with PHP's internal library, but I would assume a zval (even with it's value being null) will evaluate as true in C, causing if(z_opts) to evaluate as true.

This should work as a fix:

if(z_opts && Z_TYPE_P(z_opts) != IS_LONG && Z_TYPE_P(z_opts) != IS_ARRAY && Z_TYPE_P(z_opts) != IS_NULL) {
    RETURN_FALSE;
}

[michael-grunder]

Nice find. Essentially what's happening is that I'm treating this as an invalid call, but I think treating NULL as "not an additional argument" is fine.

I'll hotfix this for you today.

Cheers,
Mike

[nfrm]

Thanks :)

[michael-grunder]

I have hotfixed this. Try it now.

Cheers,
Mike

[nfrm]

😄

DOES NOT EXIST
EXISTS
EXISTS