Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with PHP 7.4 #432

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Jun 14, 2019

No description provided.

@smoench smoench force-pushed the fix-compatibility-with-php74 branch from f1ee5be to 4ab322a Compare June 14, 2019 10:12
@smoench
Copy link
Contributor Author

smoench commented Jun 28, 2019

@ciaranmcnulty you may have a I look at this PR and consider having another bugfix release. Currently it preventing me testing projects against PHP 7.4 without ignoring php deprecation.

Thanks in advance :-)

@stof stof merged commit dcf5389 into phpspec:master Aug 23, 2019
@smoench smoench deleted the fix-compatibility-with-php74 branch August 23, 2019 10:06
@smoench
Copy link
Contributor Author

smoench commented Aug 23, 2019

Thank you, @stof!

@theodorejb
Copy link
Contributor

Can a new release be published that includes this fix?

@jdpedrie
Copy link

@stof @ciaranmcnulty +1 to tagging a patch. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants