Allow parsing class constants with more than one wildcard in the constant name #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 5, 2021
src/Parser/ConstExprParser.php
Outdated
| @@ -61,10 +61,18 @@ public function parse(TokenIterator $tokens, bool $trimStrings = false): Ast\Con | |||
| $tokens->consumeTokenType(Lexer::TOKEN_IDENTIFIER); | |||
| if ($tokens->tryConsumeTokenType(Lexer::TOKEN_WILDCARD)) { | |||
| $classConstantName .= '*'; | |||
| if ($tokens->currentTokenType() === Lexer::TOKEN_IDENTIFIER) { | |||
There was a problem hiding this comment.
I feel like this needs a while loop - so that we can have multiple wildcards in the name :)
There was a problem hiding this comment.
OK sure, might as well do a complete solution while I'm at it I guess.
Seldaek
force-pushed
the
allow_wildcard_in_middle
branch
from
cea6e5c to
a8044ee
Compare
Seldaek
changed the title
ondrejmirtes
approved these changes
Sep 12, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs phpstan/phpstan#5534