Fix build

[staabm]

After phpstan/phpstan-src#2953 landed we don't need this whitelist of constants anymore.

[staabm]

I think the build will be green on PHP 7.2 after ondrejmirtes/BetterReflection#36 landed

[ondrejmirtes]

Thank you.

[ondrejmirtes]

Looks like the tests still fail on 7.2: https://github.com/phpstan/phpstan-deprecation-rules/actions/runs/8261289348/job/22598303664

You don't need to care about PHPStan failing, that will take care of itself when 1.10.61 is released.

[staabm]

I will have a look

[staabm]

I think the remaining problem is, that in jetbrains stubs constants are defined via define('X', 12) while the PhpStormStubsSourceStubber currently expects Const_ nodes to inspect the phpdocs. I will dig deeper

[ondrejmirtes]

Yeah, PHPDoc above define() needs to be supported as well. I thought it already works.

[staabm]

fix in phpstan/phpstan-src#2967