Buggy static analyse with phpstan/phpstan-doctrine 1.2.6 - 1.2.8

[petrparolek]

Version: 1.2.6 to 1.2.8

Very buggy static analyse - sometimes PHPStan is ok and sometimes reports manz errors

Example code:

<?php declare(strict_types = 1);

namespace App\Entities;

use Doctrine\ORM\Mapping as ORM;
use App\Repositories\CountryRepository;

#[ORM\Entity(repositoryClass: CountryRepository::class)]
#[ORM\Table(name: 'countries')]
class Country
{

	#[ORM\Id]
	#[ORM\Column(type: 'integer')]
	#[ORM\GeneratedValue]
	private int $id;

	#[ORM\Column(type: 'string', nullable: false)]
	private string $code;

	#[ORM\Column(type: 'string', nullable: false)]
	private string $country;

	public function getId(): int
	{
		return $this->id;
	}

	public function getCode(): string
	{
		return $this->code;
	}

	public function getCountry(): string
	{
		return $this->country;
	}

	public function setCode(string $code): void
	{
		$this->code = $code;
	}

	public function setCountry(string $country): void
	{
		$this->country = $country;
	}

}
?>

<?php declare(strict_types = 1);

namespace App\Repositories;

use App\Entities\Country;
use App\Model\EntityRepository;

/**
 * @extends EntityRepository<Country>
 */
final class CountryRepository extends EntityRepository
{

}
?>

<?php declare(strict_types = 1);

namespace App\Model;

use Doctrine\ORM\EntityRepository as DoctrineEntityRepository;

/**
 * @template TEntityClass of object
 * @extends  DoctrineEntityRepository<TEntityClass>
 */
abstract class EntityRepository extends DoctrineEntityRepository
{

}

tests/object-manager.php

<?php declare(strict_types = 1);

return App\Bootstrap::boot()
	->createContainer()
	->getByType(App\Model\EntityManagerDecorator::class);

phpstan.neon

parameters:
	level: 8

	doctrine:
		repositoryClass: App\Model\EntityRepository
		objectManagerLoader: tests/object-manager.php

composer packages versions:

beberlei/doctrineextensions	v1.3.0
contributte/console v0.9.1
contributte/di	v0.5.1
doctrine/annotations	1.13.2
doctrine/cache	1.12.1
doctrine/collections	1.6.8
doctrine/common	3.2.1
doctrine/dbal	2.13.7
doctrine/deprecations	v0.5.3
doctrine/event-manager	1.1.1
doctrine/inflector	2.0.4
doctrine/instantiator	1.4.0
doctrine/lexer	1.2.2
doctrine/orm	2.11.1
doctrine/persistence	2.3.0
latte/latte	v2.10.8
nette/application	v3.0.8
nette/bootstrap	v3.0.2
nette/caching	v3.0.2
nette/component-model	v3.0.2
nette/di	v3.0.12
nette/finder	v2.5.3
nette/forms	v3.0.7
nette/http	v3.0.7
nette/mail	v3.1.8
nette/neon	v3.3.2
nette/php-generator	v3.6.5
nette/robot-loader	v3.4.1
nette/routing	v3.0.2
nette/safe-stream	v2.5.0
nette/security	v3.0.6
nette/schema	v1.2.2
nette/tokenizer	v3.1.0
nette/utils	v3.2.7
nettrine/annotations	v0.7.0
nettrine/cache	v0.3.0
nettrine/dbal	v0.7.0
nettrine/extensions-beberlei	v0.2.0
nettrine/orm	v0.8.2
psr/cache	3.0.0
psr/container	2.0.2
symfony/console	v5.4.3
symfony/deprecation-contracts	v3.0.0
symfony/polyfill-ctype	v1.24.0
symfony/polyfill-intl-grapheme	v1.24.0
symfony/polyfill-intl-normalizer	v1.24.0
symfony/polyfill-mbstring	v1.24.0
symfony/polyfill-php72	v1.24.0
symfony/polyfill-php73	v1.24.0
symfony/polyfill-php80	v1.24.0
symfony/service-contracts	v3.0.0
symfony/string	v6.0.3
tracy/tracy	v2.7.8

Dev Packages
nette/tester	v2.4.1
phpstan/extension-installer	1.1.0
phpstan/phpstan	1.4.4
phpstan/phpstan-deprecation-rules	1.0.0
phpstan/phpstan-doctrine	1.2.8
phpstan/phpstan-nette	1.0.0
phpstan/phpstan-strict-rules	1.1.0

Error report:

 ------ ----------------------------------------------------------------------- 
  Line   app/Entities/Country.php                                     
 ------ ----------------------------------------------------------------------- 
  16     Property App\Entities\Country::$id is never written, only    
         read.                                                                  
         💡 See:                                                                 
         https://phpstan.org/developing-extensions/always-read-written-propert  
         ies                                                                    
 ------ ----------------------------------------------------------------------- 

[ondrejmirtes]

So sometimes you see the error in Country.php and sometimes you don’t? That’s really weird.

Can you try running with bleedingEdge too? https://phpstan.org/blog/what-is-bleeding-edge

[petrparolek]

With bleedingEdge PHPStan report no errors.

[ondrejmirtes]

Try to run it for a while, my point was that you should see more errors when PHPStan also fails with never written, only read.. Because my suspicion is that reading the metadata silently fails but bleedingEdge would show it thanks to EntityMappingExceptionRule being enabled.

[ondrejmirtes]

Also try it without objectManagerLoader, you might not need it anymore.

[petrparolek]

parameters:
	level: 8

	doctrine:
		repositoryClass: App\Model\EntityRepository
		#objectManagerLoader: tests/object-manager.php

includes:
	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

always show error:

 ------ ---------------------------------------------------------------------------------- 
  Line   app/Entities/User.php                                                      
 ------ ---------------------------------------------------------------------------------- 
  20     Property App\Entities\User::$id is never written, only read.               
         💡 See: https://phpstan.org/developing-extensions/always-read-written-properties   
 ------ ---------------------------------------------------------------------------------- 

[petrparolek]

It is very interesting most my entities are not reported only some.

[ondrejmirtes]

Is the entity autoloaded via Composer?

[petrparolek]

No, entities are loaded by Nette RobotLoader

[petrparolek]

composer.json

{
	"name": "petrparolek/some-project",
	"description": "",
	"type": "project",
	"require": {
		"php": ">= 8.0.0",

		"nette/application": "~3.0.0",
		"nette/bootstrap": "~3.0.0",
		"nette/caching": "~3.0.0",
		"nette/di": "~3.0.5",
		"nette/finder": "^2.5",
		"nette/forms": "~3.0.0",
		"nette/http": "~3.0.0",
		"nette/mail": "^3.0",
		"nette/robot-loader": "^2.4 || ^3.0",
		"nette/safe-stream": "^2.4",
		"nette/security": "~3.0.0",
		"nette/tokenizer": "^3.0",
		"nette/utils": "^3.2",
		"latte/latte": "~2.10.0",
		"tracy/tracy": "~2.7.0",

		"nettrine/dbal": "~0.7.0",
		"nettrine/orm": "~0.8.0",
		"nettrine/extensions-beberlei": "^0.2.0"
	},
	"require-dev": {
		"phpstan/phpstan": "^1.0",
		"phpstan/phpstan-deprecation-rules": "^1.0",
		"phpstan/phpstan-doctrine": "^1.0",
		"phpstan/phpstan-nette": "^1.0",
		"phpstan/phpstan-strict-rules": "^1.0",
		"phpstan/extension-installer": "^1.0",

		"nette/tester": "~2.4.0"
	},
	"autoload": {
		"psr-4": {
			"App\\": "app"
		}
	},
	"minimum-stability": "stable",
	"config": {
		"allow-plugins": {
			"phpstan/extension-installer": true
		}
	}
}

[ondrejmirtes]

That’s it, I’m not surprised it doesn’t work.

You need to load them in Composer, or create a custom script that registers RobotLoader, and pass it to PHPStan via bootstrapFiles.

[petrparolek]

Thanks! If I loaded all classes by Composer, there bno error reported

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.