Query: add test for some method calls #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this is probably not a proper fix. This is more generic issue. Looks like it is related to all methods that are overwritten in Query and use |
|
Changed to failing test till I find the issue. |
janedbal
changed the title
|
Looks like related to phpstan/phpstan#6462 |
|
This should fix it: phpstan/phpstan-src#2803 |
|
Please test this after your merged PR phpstan/phpstan-src#2803 is released :) |
janedbal
changed the title
|
It works, do you want to bump phpstan version in composer just to have this merged? |
ondrejmirtes
force-pushed
the
query-set-hint-support
branch
from
0dd23c2
to
2b0e041
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.