Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expects() support #1

Closed
wants to merge 3 commits into from
Closed

expects() support #1

wants to merge 3 commits into from

Conversation

msvrtan
Copy link
Contributor

@msvrtan msvrtan commented Aug 13, 2018

This is a copy of allows() as they are similar.

In order to test expects() in a more native way, as an inner dependency
of test under subject, lets add a Bar class that uses Foo and lets test
it
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Aug 13, 2018

Hi Miro, thanks for this! I didn't know about the expects() method. Since it's exactly the same behaviour, I think it'd be cool to reuse the same classes - you can make them parametrized by using DI - constructor parameters, and register those classes multiple times in the neon file.

I took the liberty to do this and reuse your commits with tests 😊 See my steps:

  • Some renaming: 42eecea
  • Generalizing the extensions: ce87154
  • And the final step, expects() support (just adding those services 😊) 645a0d8

I will release it now as 0.10.1 😊

@msvrtan
Copy link
Contributor Author

msvrtan commented Aug 14, 2018

Even better!

Thank you for great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants