if I assert using assertInstanceOf it must not report an error afterwards

[gmponos]

Hello

Inside a unit test I had a code like this

        $collector = $client->getProfile()->getCollector('request');

because $client->getProfile() can return false|Profile phpstan was reporting the following issue:

 20     Cannot call method getCollector() on                                                                
         false|Symfony\Component\HttpKernel\Profiler\Profile.
 ------ ---------------------------------------------------------------------------------------------------- 

I changed my code to something like this:

        $profiler = $client->getProfile();
        $this->assertInstanceOf(Profile::class, $profiler);

        $collector = $profiler->getCollector('request');

And the error was still reported. So finally I had to add this /** @var Profile $profiler */ inline docblock in order for the error not to be reported and trick PHPstan.

I believe that since you do an assertInstanceOf there is no need to display an error and having to trick PHPstan by adding inline docblock. Is this possible to be fixed?

[ondrejmirtes]

Yes, this should work as you expect it to. I suspect you don’t have the extension installed correctly or something like that. Can you post a sample repo that shows this problem?

On Sat, 16 Jun 2018 at 19:33, Mponos George ***@***.***> wrote: Hello I had a code like this: $collector = $client->getProfile()->getCollector('request'); because $client->getProfile() can return null|Profile phpstan was reporting the following issue: 20 Cannot call method getCollector() on false|Symfony\Component\HttpKernel\Profiler\Profile. ------ ---------------------------------------------------------------------------------------------------- I changed my code to something like this: $profiler = $client->getProfile(); $this->assertInstanceOf(Profile::class, $profiler); $collector = $profiler->getCollector('request'); And the error was still reported. So finally I had to add an inline docblock in order for the error not to be reported. I believe that since you do an assertInstanceOf there is no need to display an error and having to trick PHPstan by adding inline docblock. Is this possible to be fixed? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#21>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuDIWipocY0Rb4PB3grsLN-r_uP90ks5t9UFVgaJpZM4Uqjfg> .

-- Ondřej Mirtes

[gmponos]

OK. I created a test case here:

https://github.com/gmponos/phpstanphpunitest/pull/1
https://travis-ci.org/gmponos/phpstanphpunitest/jobs/393384452

[ondrejmirtes]

Isn't the problem that you're asserting:

$this->assertInstanceOf(CreatedClass::class, $class);

instead of:

$this->assertInstanceOf(CreatedClass::class, $created);

?

[gmponos]

Sorry that was a typo... i have updated the PR and travis still fails. Can you check again?

[ondrejmirtes]

I figured it out - you have a wrong version installed. This only works on dev-master, aka 0.10-dev. So instead, try this:

"phpstan/phpstan": "^0.10",
"phpstan/phpstan-phpunit": "^0.10"

And also add "minimum-stability": "dev". BTW: Using asterisks (*) as version constraints is never a good idea.

[ondrejmirtes]

PHPStan 0.10 as a stable release will be released this month.

[gmponos]

BTW: Using asterisks (*) as version constraints is never a good idea.

Yea I know it was for the test case.

This only works on dev-master

Thank you.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.