Conflict with Phpstorm resolution.

[VincentLanglet]

I'm using

"phpstan/phpstan": "0.12.*",
"phpstan/phpstan-phpunit": "0.12.*",
"phpunit/phpunit": "8.2.5",

I have warning from Phpstorm 'void' method 'getMockBuilder' result used with the following code :

$pdfGenerator = $this->getMockBuilder(PdfGenerator::class)->getMock();

When I Cmd + Click, I see Phpstorm are locating the getMockBuilder in phpstan/phpstan-phpunit/stubs (instead of inside Phpunit package, maybe he take the first one in lexical order) with the following annotation:

	/**
	 * @template T
	 * @phpstan-param class-string<T> $originalClassName
	 * @phpstan-return MockObject&T
	 */
	public function createConfiguredMock($originalClassName) {}

And theses annotations are not understood by Phpstorm.

Changing to

	/**
	 * @template T
	 * @phpstan-param class-string<T> $originalClassName
	 * @phpstan-return MockObject&T
         * @return MockBuilder
	 */
	public function createConfiguredMock($originalClassName) {}

Fix the issue.

By the way, in Phpunit code, the annotations are

/**
     * Returns a builder object to create mock objects using a fluent interface.
     *
     * @param string|string[] $className
     *
     * @psalm-template RealInstanceType of object
     * @psalm-param class-string<RealInstanceType>|string[] $className
     * @psalm-return MockBuilder<RealInstanceType>
     */
    public function getMockBuilder($className): MockBuilder
    {
        $this->recordDoubledType($className);

        return new MockBuilder($this, $className);
    }

So the returnType/paramsType are added both with the psalm syntax and the regular syntax.

Shouldn't the regular syntax be used too in the stubs provided by phpstan ?

[ondrejmirtes]

Hi, instead, I’d like to have some good way of excluding those stubs in PhpStorm. Can you figure something out? 😊

[VincentLanglet]

Hi, instead, I’d like to have some good way of excluding those stubs in PhpStorm. Can you figure something out? 😊

I have no clue about how doing it, but if I find, I'll sure tell you.

[lookyman]

You can mark directory as excluded. It appears to help.

[VincentLanglet]

You can mark directory as excluded. It appears to help.

Since it's a vendor, every developer using phpstan-phpunit has to exclude this directory ; and they have to do this every time they install the package. That's not the best solution.

Having something like a .phpstormignore feature would be great ; but I didn't find something like that.

@ondrejmirtes Actually, all I see is one of the following option

• Adding the correct @param/@return tag to every stubs.
• Writing stubs differently, for example by using another namespace than the library and having some phpstan config file to match the stub with the real file.

I do like the second option, but I don't know how hard is it to implement this.

[lookyman]

Since it's a vendor

Yea, that is a problem, I agree.

[ondrejmirtes]

I released new versions of phpstan-phpunit, phpstan-doctrine and phpstan-mockery where this should no longer be a problem. I renamed those files from .php to .stub.

[VincentLanglet]

@ondrejmirtes Thanks !
I think it should be the same for https://github.com/phpstan/phpstan-symfony and https://github.com/phpstan/phpstan-nette

[ondrejmirtes]

Done

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.