added preg_filter return-type extension
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Feb 18, 2022
| if (count($functionCall->getArgs()) < 1) { | ||
| if ($argsCount < 1) { |
staabm
commented
Feb 18, 2022
Comment on lines
+9
to
+23
| function doFoo() { | ||
| $subject = array('1', 'a', '2', 'b', '3', 'A', 'B', '4'); | ||
| $pattern = array('/\d/', '/[a-z]/', '/[1a]/'); | ||
| $replace = array('A:$0', 'B:$0', 'C:$0'); | ||
|
|
||
| assertType('array<int, string>', preg_filter($pattern, $replace, $subject)); | ||
| } | ||
|
|
||
| function doFoo1() { | ||
| $subject = array('1', 'a', '2', 'b', '3', 'A', 'B', '4'); | ||
| assertType('array<int, string>', preg_filter('/\d/', '$0', $subject)); | ||
|
|
||
| $subject = 'hallo'; | ||
| assertType('string|null', preg_filter('/\d/', '$0', $subject)); | ||
| } |
There was a problem hiding this comment.
tests taken from the php.net manual
clxmstaab
force-pushed
the
preg-filter
branch
2 times, most recently
from
98c57d7 to
a4a8f93
Compare
ondrejmirtes
requested changes
Feb 23, 2022
clxmstaab
force-pushed
the
preg-filter
branch
2 times, most recently
from
34050e9 to
a03ce88
Compare
clxmstaab
force-pushed
the
preg-filter
branch
2 times, most recently
from
8bbdee9 to
47a07b9
Compare
ondrejmirtes
force-pushed
the
preg-filter
branch
from
47a07b9 to
fee978a
Compare
|
Thank you! |
|
Thank you @staabm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#6664