New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix substr return type on php<8 #1036

Merged

ondrejmirtes merged 4 commits into phpstan:master from Seldaek:patch-5

Feb 24, 2022

Contributor

Seldaek commented Feb 24, 2022 •

edited

See https://3v4l.org/PYGvv

The point would be to avoid warnings when checking against a false value, or casting (string) substr() for safety.

Seldaek added 4 commits

February 24, 2022 10:54


          Fix substr return type on php<8

cdb3265


          Add new return type to php80delta

05f9e65


          Use benevolent union instead

6985e29


          Use benevolent union instead

8c31868

ondrejmirtes merged commit 91e7ffc into phpstan:master

Member

ondrejmirtes commented Feb 24, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment