Fix/issue 6758 #1059
Fix/issue 6758 #1059
Conversation
| continue; | ||
| } | ||
| if (!$fetchNode->name instanceof Node\Identifier) { | ||
| if ($fetchNode->class instanceof Node\Expr\Variable && $fetchNode->class->name === 'this') { |
There was a problem hiding this comment.
This isn't a general fix for this problem. For example it's not gonna fix this scenario:
$self = $this;
echo $self::HELLO;or this:
$self = new self();
echo $self::HELLO;The correct fix this: Acknowledge that ClassConstFetch::$class can contain either a Name or an Expr.
If it's a Name then just check the class name using $scope->resolveName(). If it's an Expr, get type using $scope->getType(). If it's a TypeWithClassName, continue and treat it the same way as the Name in ClassConstFetch::$class.
There was a problem hiding this comment.
Thank you for your great pointers.
I didn't even know that the first example is a valid syntax! Fixing now.
| public function testBug6758(): void | ||
| { | ||
| if (!self::$useStaticReflectionProvider) { | ||
| $this->markTestSkipped('Test requires static reflection'); |
There was a problem hiding this comment.
Why static reflection? There's nothing special about the file.
There was a problem hiding this comment.
Sorry, I'm not sure about why this is need that much, but I added because it failed with
05: Class Bug6758\HelloWorld was not found while trying to analyse it - discovering symbols is probably not configured properly.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbol
without reflection in local testing.
I can run testRule() with no errors by the way...
There was a problem hiding this comment.
You need to run composer dump after you add a new class.
There was a problem hiding this comment.
Thanks.
I didin't know about classmaps...
|
Thank you! |
fixes phpstan/phpstan#6758