Implement locateIdentifiersByType for OptimizedSingleFileSourceLocator #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfejfar
force-pushed
the
tf-locateIdentifiersByType
branch
3 times, most recently
from
3ec23e3 to
08c63d9
Compare
ondrejmirtes
requested changes
Mar 29, 2022
|
@ondrejmirtes I kind of extrapolated from #1080 (comment). It felt weird that if I'm looking in directory constants are not located, but when I look at single file, they are. |
|
I just want |
ondrejmirtes
force-pushed
the
tf-locateIdentifiersByType
branch
from
08c63d9 to
54c41bc
Compare
ondrejmirtes
approved these changes
Oct 26, 2022
|
I took it over the finish line, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1080