Support named arguments when resolving template parameters #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps this should target 1.5.x? |
staabm
reviewed
Mar 31, 2022
|
just to make sure it isn't forgotten: regarding named arguments there is some other work prepared in #750 , where we also had some discussion. this PR touches other files though, so it seems there is no overlap and everything is fine. |
ondrejmirtes
force-pushed
the
named-generic
branch
from
c59e741 to
a6ae08e
Compare
|
I rebased it on top of 1.5.x because yeah, this is just a bugfix :) |
|
Thank you very much! The logic seems too easy but I wasn't able to find any flaw in it. |
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#5262