Avoid describing ConstantArrayType values twice #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First baby-step to making nested
ConstantArrayTypehandling faster.I noticed that
describeis really slow for deeply nested constant arrays. So not calling describe for them twice can make quite a difference. For "normal" constant arrays I guess this is not more than a micro optimisation.Don't expect any immediate follow-up PRs please..
describe(which is used for super type checks too AFAIK) seems to be quite an important bit to improve and there is more to do here, but it is for sure not everything that is making the nested constant arrays slow.