Remove unnecessary ConstantArrayType::getKeyType #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed because
keyTypesis never modified directly inside the class. E.g.setOffsetValueTypeis usingConstantArrayTypeBuilder, which creates a newConstantArrayType, which unions the keys again before passing them to theArrayTypeparent. Meaning,parent::getKeyTypeis always save to use and contains the latest union already.So this saves another union operation there and should, in theory, improve performance. But the problematic scenarios that I have lying around seem to be not affected by it and therefore I can't deliver a good-looking before/after comparison. But anyways, unnecessary code is unnecessary code :)