Handle side effects of constructor calls

src/Analyser/NodeScopeResolver.php

@@ -1996,7 +1996,7 @@ function (MutatingScope $scope) use ($expr, $nodeCallback, $context): Expression
 			$scope = $result->getScope();
 			if ($methodReflection !== null) {
 				$hasSideEffects = $methodReflection->hasSideEffects();
-				if ($hasSideEffects->yes()) {
+				if ($hasSideEffects->yes() || $methodReflection->getName() === '__construct') {
 					$scope = $scope->invalidateExpression($expr->var, true);
 					foreach ($expr->getArgs() as $arg) {
 						$scope = $scope->invalidateExpression($arg->value, true);
@@ -2118,7 +2118,10 @@ function (MutatingScope $scope) use ($expr, $nodeCallback, $context): Expression
 			if (
 				$methodReflection !== null
 				&& !$methodReflection->isStatic()
-				&& $methodReflection->hasSideEffects()->yes()
+				&& (
+					$methodReflection->hasSideEffects()->yes()
+					|| $methodReflection->getName() === '__construct'
+				)
 				&& $scopeFunction instanceof MethodReflection
 				&& !$scopeFunction->isStatic()
 				&& $scope->isInClass()
@@ -2131,7 +2134,7 @@ function (MutatingScope $scope) use ($expr, $nodeCallback, $context): Expression
 			}
 
 			if ($methodReflection !== null) {
-				if ($methodReflection->hasSideEffects()->yes()) {
+				if ($methodReflection->hasSideEffects()->yes() || $methodReflection->getName() === '__construct') {
 					foreach ($expr->getArgs() as $arg) {
 						$scope = $scope->invalidateExpression($arg->value, true);
 					}
@@ -2444,6 +2447,12 @@ function (MutatingScope $scope) use ($expr, $nodeCallback, $context): Expression
 							$expr->getArgs(),
 							$constructorReflection->getVariants(),
 						);
+						$hasSideEffects = $constructorReflection->hasSideEffects();
+						if ($hasSideEffects->yes()) {
+							foreach ($expr->getArgs() as $arg) {
+								$scope = $scope->invalidateExpression($arg->value, true);
+							}
+						}
 						$constructorThrowPoint = $this->getConstructorThrowPoint($constructorReflection, $classReflection, $expr, $expr->class, $expr->getArgs(), $scope);
 						if ($constructorThrowPoint !== null) {
 							$throwPoints[] = $constructorThrowPoint;

src/Reflection/Php/PhpMethodReflection.php

@@ -413,10 +413,6 @@ public function hasSideEffects(): TrinaryLogic
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
 
-		if ($isVoid) {
-			return TrinaryLogic::createYes();
-		}
-
 		return TrinaryLogic::createMaybe();
 	}
 

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -265,6 +265,7 @@ public function dataFileAsserts(): iterable
 
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-4343.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/impure-method.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/impure-constructor.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-4351.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/var-above-use.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/var-above-declare.php');

tests/PHPStan/Analyser/data/impure-constructor.php

@@ -0,0 +1,130 @@
+<?php
+
+namespace ImpureConstuctor;
+
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+	/** @var bool */
+	private $active;
+
+	public function __construct()
+	{
+		$this->active = false;
+	}
+
+	public function getActive(): bool
+	{
+		return $this->active;
+	}
+
+	public function activate(): void
+	{
+		$this->active = true;
+	}
+
+}
+
+
+class ClassWithImpureConstructorNotMarked
+{
+
+	public function __construct(Foo $foo)
+	{
+		$foo->activate();
+	}
+
+}
+
+class ClassWithImpureConstructorMarked
+{
+
+	/**
+	 * @phpstan-impure
+	 */
+	public function __construct(Foo $foo)
+	{
+		$foo->activate();
+	}
+
+}
+
+class ClassWithPureConstructorMarked
+{
+
+	/**
+	 * @phpstan-pure
+	 */
+	public function __construct(Foo $foo)
+	{
+	}
+
+}
+
+class ClassWithImpureConstructorNotMarkedWithoutParameters
+{
+
+	/** @var string */
+	private $lorem;
+
+	public function __construct()
+	{
+		$this->lorem = 'lorem';
+	}
+
+}
+
+class Test
+{
+
+	public function testClassWithImpureConstructorNotMarked()
+	{
+		$foo = new Foo();
+		assertType('bool', $foo->getActive());
+
+		assert(!$foo->getActive());
+		assertType('false', $foo->getActive());
+
+		new ClassWithImpureConstructorNotMarked($foo);
+		assertType('false', $foo->getActive());
+	}
+
+	public function testClassWithImpureConstructorMarked()
+	{
+		$foo = new Foo();
+		assertType('bool', $foo->getActive());
+
+		assert(!$foo->getActive());
+		assertType('false', $foo->getActive());
+
+		new ClassWithImpureConstructorMarked($foo);
+		assertType('bool', $foo->getActive());
+	}
+
+	public function testClassWithPureConstructorMarked()
+	{
+		$foo = new Foo();
+		assertType('bool', $foo->getActive());
+
+		assert(!$foo->getActive());
+		assertType('false', $foo->getActive());
+
+		new ClassWithPureConstructorMarked($foo);
+		assertType('false', $foo->getActive());
+	}
+
+	public function testClassWithImpureConstructorNotMarkedWithoutParameters()
+	{
+		$foo = new Foo();
+		assertType('bool', $foo->getActive());
+
+		assert(!$foo->getActive());
+		assertType('false', $foo->getActive());
+
+		new ClassWithImpureConstructorNotMarkedWithoutParameters();
+		assertType('false', $foo->getActive());
+	}
+
+}