Improve variadic parameter support in array_merge
#1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
improve-variadic-param-support-in-array-merge
branch
from
e1e79c5 to
6e919a7
Compare
|
Thank you! |
|
In case I start looking into extracting some of the complexity - assuming it is really a refactor and does not change behaviour, shall I open the PR against 1.5.x or 1.6.x? But it might take me a couple of days anyways, maybe over the weekend.. |
|
You can do it in 1.6.x, the end for 1.5.x is near anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there's room to improve because of phpstan/phpstan#7068 (comment).
Improves 2 things related to variadic parameters
e.g.
assertType('array{17}', array_merge([], ...[[17]]));would previously benon-empty-array<0, 17>e.g.
assertType('array<int>', array_merge([], ...$bar1));would previously benon-empty-array<int>Still not happy about the complexity variadic and constant array param handling introduces. Maybe things could get cleaned up a bit in general via some helper utilities for such cases. I could take a look at refactoring this later I guess.