Expose default values for native functions/methods #1261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
force-pushed
the
default-values-for-native
branch
from
e992f3c to
570e366
Compare
rvanvelzen
commented
Apr 28, 2022
| use function PHPStan\Testing\assertType; | ||
|
|
||
| function () { | ||
| assertType('ArrayObject<*NEVER*, *NEVER*>', new \ArrayObject()); |
There was a problem hiding this comment.
This isn't ideal but matches the behavior with the actual default value passed (which is the next line)
rvanvelzen
changed the title
|
Hmm, obviously this won't work for PHP<8 :/ |
|
Oh, you have no idea what you’ve signed up for 😊 This will unblock multiple nice things but I have to do sime preliminary work first and then I’ll get back to you 😊 |
|
FYI @rvanvelzen I'm aware of your many PRs you sent in the last 24 hours, but I first want to finish my promise of the work needed for this area, and then I'll look at the other PRs :) |
|
@ondrejmirtes no worries, it gives me enough time to work on implementing |
|
Alright, doing as promised, here's the description of what I want from you: #1276 (comment) Thanks :) |
7 tasks
|
Superseded by #1300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help getting #1244 over the finish line