Skip to content

Fix stream_bucket_make_writeable #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2022
Merged

Fix stream_bucket_make_writeable #1361

merged 2 commits into from
May 29, 2022

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented May 29, 2022 •
edited
Loading

@VincentLanglet VincentLanglet marked this pull request as ready for review May 29, 2022 13:29
@VincentLanglet VincentLanglet mentioned this pull request May 29, 2022
Closed
@ondrejmirtes
Copy link
Member

This doesn't need AnalyserIntegrationTest, that's too heavy-handed. NodeScopeResolverTest file would be better.

@VincentLanglet
Copy link
Contributor Author

This doesn't need AnalyserIntegrationTest, that's too heavy-handed. NodeScopeResolverTest file would be better.

Sure done

@ondrejmirtes ondrejmirtes merged commit 3ec3b64 into phpstan:1.7.x May 29, 2022
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream_bucket_make_writeable gives Access to an undefined property object::$data.
2 participants
@VincentLanglet @ondrejmirtes