Skip to content

Added <file>bin</file> into phpcs.xml. and applied it. #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

Added <file>bin</file> into phpcs.xml. and applied it. #1394

merged 1 commit into from
Jun 3, 2022

Conversation

sasezaki
Copy link
Contributor

@sasezaki sasezaki commented Jun 3, 2022

I could not see any reason to not .

@ondrejmirtes ondrejmirtes merged commit 2ef9a53 into phpstan:1.7.x Jun 3, 2022
@ondrejmirtes
Copy link
Member

Great, thank you! Although it comes with a catch or two:

  1. It wasn't applied to bin/phpstan because of the file extension
  2. Not all sniffs can apply to bin/phpstan - about using features from newer PHP versions, because the file isn't being downgraded during the compilation process in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasezaki @ondrejmirtes