Add dynamic return type extension for date_create #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
dateCreate
branch
from
5a2d950 to
20d5398
Compare
VincentLanglet
force-pushed
the
dateCreate
branch
from
20d5398 to
5cbc0b7
Compare
ondrejmirtes
requested changes
Jun 13, 2022
| use function in_array; | ||
|
|
||
| class DateTimeDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension | ||
| { | ||
|
|
||
| public function isFunctionSupported(FunctionReflection $functionReflection): bool | ||
| { | ||
| return in_array($functionReflection->getName(), ['date_create_from_format', 'date_create_immutable_from_format'], true); | ||
| return in_array($functionReflection->getName(), ['date_create', 'date_create_immutable'], true); |
There was a problem hiding this comment.
I can't read this diff. Please give a different name to your new extension and don't change an existing file.
There was a problem hiding this comment.
Diff should be better now.
ondrejmirtes
requested changes
Jun 13, 2022
| $datetime = $scope->getType($functionCall->getArgs()[0]->value); | ||
|
|
||
| if (!$datetime instanceof ConstantStringType) { | ||
| return $defaultReturnType; |
There was a problem hiding this comment.
The code of the extension can be simplified now. Instead of $defaultReturnType, you can simply return null here.
There was a problem hiding this comment.
Is it better now ?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.