Reindex constant arrays via shuffle

[herndlm]

Closes phpstan/phpstan#6138

While this is an improvement I'm not a 100% happy with it, because the constant array still dictates the same order of values after shuffle, which is not correct. But generalizing it to a normal array would loose the key order I presume? Better ideas?

[ondrejmirtes]

I'd say the array should be general (ArrayType) after shuffle because the key => value type association is no longer maintained - ConstantArrayType is no longer correct.

[herndlm]

I had the same thought but then we loose the keys I guess. But OK, I'll look into that tomorrow

[herndlm]

"tomorrow" = ~2 weeks in the parallel universe I was living :)

should be adapted. shuffle leads now to a generic array and re-indexes the keys. The only thing that was lost is the order of the keys which is always 0, 1, 2, .. but I guess we can't retain them at the moment.

[herndlm]

Not a 100% happy with this, but I can't come up with something better. Basically something like a shuffled list / shuffled constant array would be needed, but that feels very much like an edge case :)

[ondrejmirtes]

Thank you.