Add RegexIterator stub.
#1462
Merged
Add RegexIterator stub.
#1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jun 23, 2022
| * | ||
| * @template-extends FilterIterator<TKey, TValue, TIterator> | ||
| */ | ||
| class RegexIterator extends FilterIterator { |
There was a problem hiding this comment.
Needs to be in skipCheckGenericClasses
stubs/iterable.stub
Outdated
| public function __construct(Iterator $iterator, string $regex, int $mode = self::MATCH, int $flags = 0, int $preg_flags = 0) {} | ||
|
|
||
| /** | ||
| * @return TValue|null |
There was a problem hiding this comment.
Please do not add the |null part here.
There was a problem hiding this comment.
I got rid of the method as we are extending FilterIterator.
There was a problem hiding this comment.
Actually those methods are not defined in FilterIterator. Adding them back and remove the null.
stubs/iterable.stub
Outdated
| public function current() {} | ||
|
|
||
| /** | ||
| * @return TKey|null |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.