Better support for autoloader edge cases #1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support autoloaders that rely on the include path and don't check file existence before trying to include a file.
Autoloaders not checking file existence before trying to include the file need a proper response from
stream_open
. This is something that wouldn't happen with PHP based autoloaders, but C based autoloaders may rely on the return value ofphp_stream_open_for_zend_ex()
.Autoloaders may not always know the exact physical location of the file they need to load, and instead rely on the availability of the file somewhere in the include path. In order for phpstan to also find those files, rather than just an
is_file()
check, it would also need to check availability in the include path withstream_resolve_include_path()
.Fixes phpstan/phpstan#7526, which also contains more background info.