Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify InArrayFunctionTypeSpecifyingExtension #1510

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Jul 12, 2022

I know this is not changing much, but I'm currently looking at improving the impossible checks there and had this change lying around and wanted to throw it out already. if that makes sense..

It mostly moves the last specifying block (for a non-empty-array haystack) inside the haystack specifying block. this feels like one thing less to worry for me that might mess things up and hopefully it helps when I have to add more checks. but so far this stuff only lead to headaches.. :)

@herndlm herndlm marked this pull request as ready for review July 12, 2022 11:55
@ondrejmirtes ondrejmirtes merged commit 2cd83b2 into phpstan:1.8.x Jul 12, 2022
@ondrejmirtes
Copy link
Member

Thank you :)

@herndlm herndlm deleted the simplify-in-array-extension branch July 12, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants