Skip to content

fix sscanf() inference with regex format patterns #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

fix sscanf() inference with regex format patterns #1576

merged 3 commits into from
Aug 25, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 1, 2022 •
edited
Loading

@staabm staabm force-pushed the fix7563 branch 2 times, most recently from 4aa44f1 to f044305 Compare August 5, 2022 15:29
@staabm staabm mentioned this pull request Aug 9, 2022
Closed
@rvanvelzen
Copy link
Contributor

This fails for '%[%[]' which should have size 1.

@staabm
Copy link
Contributor Author

staabm commented Aug 9, 2022 •
edited
Loading

This fails for '%[%[]' which should have size 1.

good catch, fixed

@staabm staabm force-pushed the fix7563 branch 2 times, most recently from 2ce76d1 to 986e8ba Compare August 9, 2022 14:31
@Alkarex Alkarex mentioned this pull request Aug 9, 2022
Merged
@staabm staabm force-pushed the fix7563 branch 4 times, most recently from b23d682 to 93d5a56 Compare August 25, 2022 15:55
@staabm
Copy link
Contributor Author

staabm commented Aug 25, 2022

rebased

@ondrejmirtes ondrejmirtes merged commit e0f2c89 into phpstan:1.8.x Aug 25, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the fix7563 branch August 26, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sscanf array bug Sscanf Array Index
3 participants
@staabm @rvanvelzen @ondrejmirtes