Skip to content

sscanf: allow nulls in returned array #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

sscanf: allow nulls in returned array #1577

merged 1 commit into from
Aug 25, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 1, 2022

@staabm staabm marked this pull request as ready for review August 1, 2022 13:41
@ondrejmirtes ondrejmirtes merged commit e722017 into phpstan:1.8.x Aug 25, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the sscanf branch August 25, 2022 13:18
@ondrejmirtes
Copy link
Member

@staabm Please fix tests on 1.8.x, I didn't check before rebasing and there were some conflicting asserts.

@herndlm herndlm mentioned this pull request Aug 25, 2022
Merged
@herndlm
Copy link
Contributor

herndlm commented Aug 25, 2022

@staabm Please fix tests on 1.8.x, I didn't check before rebasing and there were some conflicting asserts.

noticed them as well when I rebased my PR :) #1652

@staabm
Copy link
Contributor Author

staabm commented Aug 25, 2022

Thank you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sscanf can return nulls
3 participants
@staabm @ondrejmirtes @herndlm