Skip to content

Add return type stub for SimpleXMLElement::asXML #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Add return type stub for SimpleXMLElement::asXML #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions stubs/iterable.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,16 @@ class Generator implements Iterator
class SimpleXMLElement implements Traversable, ArrayAccess, Iterator, RecursiveIterator
{

/**
* @return ($filename is null ? string|false : bool)
*/
public function asXML(?string $filename = null) { }

/**
* @return ($filename is null ? string|false : bool)
*/
public function saveXML(?string $filename = null) { }

}

/**
Expand Down
23 changes: 23 additions & 0 deletions tests/PHPStan/Analyser/data/simplexml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,26 @@ public function getAddressByGps()
}

}

class AsXML
{

public function asXML(): void
{
$element = new SimpleXMLElement('');

assertType('string|false', $element->asXML());

assertType('bool', $element->asXML('/tmp/foo.xml'));
}

public function saveXML(): void
{
$element = new SimpleXMLElement('');

assertType('string|false', $element->saveXML());

assertType('bool', $element->saveXML('/tmp/foo.xml'));
}

}