More specific type for 'port' component of 'parse_url()' #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Aug 15, 2022
| @@ -122,17 +122,17 @@ private function cacheReturnTypes(): void | |||
| } | |||
|
|
|||
| $string = new StringType(); | |||
| $integer = new IntegerType(); | |||
| $port = new IntegerRangeType(0, 65535); | |||
There was a problem hiding this comment.
should use IntegerRangeType::fromInterval(...)
There was a problem hiding this comment.
interesting, brb opening a PR that prevents that :)
There was a problem hiding this comment.
I would've never guessed that! Force-pushed with the requested change.
thg2k
force-pushed
the
pr/parse_url_intrange
branch
from
e2e38c9 to
9775464
Compare
thg2k
force-pushed
the
pr/parse_url_intrange
branch
from
9775464 to
547e608
Compare
|
I'm sorry I just realized I missed a couple of tests, gotta love that CI. Made another force push to fix that, let me know if there are other outstanding issues. |
Yeah, I'm super-proud of that, thanks :) And thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
portcomponent can only be in the range 0-65535: