Skip to content

Make IntegerRangeType constructor private #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Make IntegerRangeType constructor private #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Type/IntegerRangeType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@
class IntegerRangeType extends IntegerType implements CompoundType
{

public function __construct(private ?int $min, private ?int $max)
private function __construct(private ?int $min, private ?int $max)
{
// this constructor can be made private when PHP 7.2 is the minimum
parent::__construct();
assert($min === null || $max === null || $min <= $max);
assert($min !== null || $max !== null);
Expand Down
6 changes: 3 additions & 3 deletions tests/PHPStan/Type/TypeCombinatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,8 +2101,8 @@ public function dataUnion(): iterable
];
yield [
[
new MixedType(false, new IntegerRangeType(17, null)),
new IntegerRangeType(19, null),
new MixedType(false, IntegerRangeType::fromInterval(17, null)),
IntegerRangeType::fromInterval(19, null),
],
MixedType::class,
'mixed~int<17, 18>=implicit',
Expand Down Expand Up @@ -3603,7 +3603,7 @@ public function dataIntersect(): iterable
];
yield [
[
new MixedType(false, new IntegerRangeType(17, null)),
new MixedType(false, IntegerRangeType::fromInterval(17, null)),
new MixedType(),
],
MixedType::class,
Expand Down