fix *never* type for more operators #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
reviewed
Aug 25, 2022
Comment on lines
+671
to
+679
| $callbackLeftType = $getTypeCallback($left); | ||
| $callbackRightType = $getTypeCallback($right); | ||
|
|
||
| if ($callbackLeftType instanceof NeverType || $callbackRightType instanceof NeverType) { | ||
| return new NeverType(); | ||
| } | ||
|
|
||
| $leftTypes = TypeUtils::getConstantScalars($callbackLeftType); | ||
| $rightTypes = TypeUtils::getConstantScalars($callbackRightType); |
There was a problem hiding this comment.
what do you think of also calling them $leftType and $rightType instead of $callbackLeftType and $callbackRightType? I think then it would be consistent with other methods from here
There was a problem hiding this comment.
it collides with a already same named variable in the loop below (therefore I went with callbackLeftType, as I used $leftType before and phpstan reported same named variables ;))
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #1641 and #1579 (comment)
//cc @herndlm