Use TypeUtils::getOldConstantArrays in array_fill_keys extension #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
changed the title
|
This time I opened it with the wrong title and forgot to change commit messages. Ondrej, please show mercy :D |
herndlm
changed the title
herndlm
force-pushed
the
array-fill-keys-get-old-constant-arrays
branch
from
ef73a7e
to
a39e570
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jfyi: an optional key that is not at the end of the array will lead to a union key which will lead to generalization to a generic array via the ConstantArrayBuilder, which makes sense since a union cannot be used as key. this is not changed behaviour but surprised me for a second when I added optional key tests :)