Use TypeUtils::getOldConstantArrays in array_column extension

[herndlm]

looks like it made it a tiny bit smarter. testImprecise4 was converted to testConstantArray12

[ondrejmirtes]

BTW if you don't plan to make more changes and if you're not just experimenting, you don't need to open the PR as a draft. The problem is that I don't get an email notification when you mark it as ready for review.

if you're just waiting for CI results, you can open it as ready-to-merge from the start. If the CI looks green I can merge it sooner.

[herndlm]

Good to know. Yeah, just always anxious that ci might be red. Like here :)

[herndlm]

how do you wish to have the new Type::getConstantArrays() implemented? :)
return an empty array everywhere there are none directly or via trait? UPDATE: maybe I should study existing traits first..

[ondrejmirtes]

Yeah, ConstantArrayType should return [$this], UnionType should merge the results from all the types.

IntersectionType I'm not sure about, you can have ConstantArrayType&NonEmptyArrayType...

[ondrejmirtes]

And please search and replace the usages programatically, either with a regex in PhpStorm, or write a script that uses PhpParser format-preserving printer and just switch those AST nodes around in a node visitor :) Here's an example: https://github.com/nikic/PHP-Parser/blob/master/doc/component/Pretty_printing.markdown#formatting-preserving-pretty-printing

[herndlm]

Yeah, ConstantArrayType should return [$this], UnionType should merge the results from all the types.

IntersectionType I'm not sure about, you can have ConstantArrayType&NonEmptyArrayType...

right, but I meant mostly how e.g. IntegerType should implement it. I wonder if I should create a new e.g. NotConstantArrayType trait or just implement it returning an empty array in most of the types

[ondrejmirtes]

Both are valid to me :) I don't like the traits too much but we already accepted that direction so it's fine for me.

[herndlm]

fyi I have the Type::getConstantArrays adaption ready and will open the PR after this one got merged :)

[ondrejmirtes]

Alright, thank you :)