Fix ConstantArrayType::isKeysSupersetOf for tagged unions #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7898
Looks like the type comparison was mixed up here, I'm surprised that this wasn't noticed so far and wonder if this has more implications 🤔 But I have to admit that this was more a lucky guess, I did not fully understand it yet tbh.
UPDATE: I think I got it, basically it correctly skips the removal of the other arrays same key now, if it's value is a narrower type. before it would do it the other way around which could lead to a false-positive true return and therefore information loss, if I'm right.