Add dump-parameters command #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 6, 2022
src/Command/DumpConfigCommand.php
Outdated
| new InputArgument('paths', InputArgument::OPTIONAL | InputArgument::IS_ARRAY, 'Paths with source code to run analysis on'), | ||
| new InputOption('configuration', 'c', InputOption::VALUE_REQUIRED, 'Path to project configuration file'), | ||
| new InputOption(AnalyseCommand::OPTION_LEVEL, 'l', InputOption::VALUE_REQUIRED, 'Level of rule options - the higher the stricter'), | ||
| new InputOption('autoload-file', 'a', InputOption::VALUE_REQUIRED, 'Project\'s additional autoload file path'), |
There was a problem hiding this comment.
I think we can remove paths, but add memory-limit here.
Basically the arguments/options should mirror ClearResultCacheCommand, and add level because that influences the loaded file :)
rvanvelzen
force-pushed
the
dump-config
branch
from
ba71dcf to
5a386e4
Compare
rvanvelzen
force-pushed
the
dump-config
branch
from
5a386e4 to
468f56e
Compare
ondrejmirtes
approved these changes
Sep 6, 2022
|
Hmm, so lint wants me to add the trailing comma, but the downgrade doesn't remove it so it doesn't work on <7.3 😞 |
|
Is it the trailing comma in the unset? That's probably a Rector downgrade bug. You can unset each key individually on a separate line I guess. |
rvanvelzen
force-pushed
the
dump-config
branch
from
468f56e to
0e35ce7
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by phpstan/phpstan#7942. Not saying this is a good idea, but the implementation is almost trivial :)