Fix supertype checks between int range and constant int union #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
force-pushed
the
bug-3383
branch
from
97eb6e2 to
4f3f314
Compare
|
This is gonna fix quite a lot of issues I think :) |
rvanvelzen
force-pushed
the
bug-3383
branch
from
4f3f314 to
33292ba
Compare
staabm
reviewed
Sep 22, 2022
ondrejmirtes
requested changes
Sep 22, 2022
rvanvelzen
force-pushed
the
bug-3383
branch
3 times, most recently
from
0390d8d to
46a7ad1
Compare
ondrejmirtes
force-pushed
the
bug-3383
branch
from
46a7ad1 to
19edfe0
Compare
ondrejmirtes
force-pushed
the
bug-3383
branch
from
19edfe0 to
1f51ae4
Compare
|
This is green now 🎉 |
|
Thank you! |
|
really cool. free free to ping me for regression tests.. just in case there are too many |
|
These are fixed and in need of regression tests: phpstan/phpstan#6356 + phpstan/phpstan#7594 Additionally, I'd like if there were more tests checking when the integer range/constant integer combo does NOT accept each other, and also some tests and support for open intervals (when min or max are not defined). |
This was referenced Sep 23, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpstan/phpstan#3383