Refined fpm_get_status function signature.

[mad-briller]

https://www.php.net/manual/en/function.fpm-get-status.php
https://www.php.net/manual/en/fpm.status.php#fpm.status.contents

An example from a local vagrant machine:

^ array:15 [▼
  "pool" => "admin"
  "process-manager" => "dynamic"
  "start-time" => 1664364711
  "start-since" => 3810
  "accepted-conn" => 7
  "listen-queue" => 0
  "max-listen-queue" => 0
  "listen-queue-len" => 0
  "idle-processes" => 1
  "active-processes" => 1
  "total-processes" => 2
  "max-active-processes" => 1
  "max-children-reached" => 0
  "slow-requests" => 0
  "procs" => array:2 [▼
    0 => array:14 [▼
      "pid" => 770
      "state" => "Running"
      "start-time" => 1664364711
      "start-since" => 3810
      "requests" => 4
      "request-duration" => 33595
      "request-method" => "GET"
      "request-uri" => "/admin/index.php"
      "query-string" => ""
      "request-length" => 0
      "user" => "-"
      "script" => "/vagrant/admin/public/index.php"
      "last-request-cpu" => 0.0
      "last-request-memory" => 0
    ]
    1 => array:14 [▼
      "pid" => 771
      "state" => "Idle"
      "start-time" => 1664364711
      "start-since" => 3810
      "requests" => 3
      "request-duration" => 73026
      "request-method" => "GET"
      "request-uri" => "/admin/index.php"
      "query-string" => ""
      "request-length" => 0
      "user" => "-"
      "script" => "/vagrant/admin/public/index.php"
      "last-request-cpu" => 54.775010415373
      "last-request-memory" => 4194304
    ]
  ]
]

[mad-briller]

active-processes and total-processes must be atleast 1 or this function will not have been called

[mad-briller]

i added a test for this because that array shape is way too complex for a human to eyeball, but i'm seeing a failure because phpstan still thinks false can be returned from fpm_get_status

i've checked the jetbrains stubs and they have @return array so i'm not sure where phpstan is getting that information from.

unfortunately the CI doesn't seem to be running on pr's at the moment so it can't really be seen on here

[mad-briller]

ah i've found it, it's here:
https://github.com/phpstan/php-8-stubs/blob/8214b152847de42ff4cf77ce6242fa150eb3f503/stubs/sapi/fpm/fpm/fpm_get_status.php

and there PR that added fpm_get_status is here, which clearly shows RETURN_FALSE:
https://github.com/php/php-src/pull/3182/files#diff-0354097cf69667d6a030457e558abb7f479910bf797bc019124738f1fb3edd93R1556

so i'm not sure what to believe 😅

[mad-briller]

reading php-src it seems that false can be returned if the fpm scoreboard is absent or already locked, so the php.net docs are optimistic at best

[ondrejmirtes]

Thank you.