Extract IssetHelper from MutatingScope #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
extract-isset-helper
branch
3 times, most recently
from
09c57e7 to
8cb2861
Compare
|
weird, I don't understand what's going on with the incompatible ScopeFactory::create error, I can't explain how the changes here would lead to that. Is this related to downgrading the code? |
herndlm
force-pushed
the
extract-isset-helper
branch
3 times, most recently
from
5022643 to
c675c4a
Compare
herndlm
force-pushed
the
extract-isset-helper
branch
from
c675c4a to
7946a35
Compare
|
also: I just realised now that |
|
I guess the goal could be to use either MutatingScope::issetCheck or the IssetCheck class. No need for another way of doing this :) I'll try to figure it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be the precondition to cleanup
IssetCheckand to another PR I'm currently working on :)Not sure about class and method names, any suggestions appreciated