Add Type::getFirstIterableKeyType() and Type::getLastIterableKeyType()
#1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
key-first-last
branch
2 times, most recently
from
3c5f52e to
7882270
Compare
|
This one should be rebased now. In the future it'd make sense to only send one PR at a time - you'll always apply learnings from the earlier PRs in the later PRs. It's my preferred workflow. |
herndlm
force-pushed
the
key-first-last
branch
from
7882270 to
423b2d5
Compare
yeah, I definitely agree and also normally work like that. in this case the motivation took over. but I stopped after the first one since I knew it would end in rebase hell :D |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty sure this will conflict with my other PR in at least one file, but I'll just fix that when the time comes