Skip to content

Fix resolving class types in inherited docblock #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix resolving class types in inherited docblock #1815

merged 1 commit into from
Oct 11, 2022

Conversation

rvanvelzen
Copy link
Contributor

ondrejmirtes
ondrejmirtes requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional NodeScopeResolverTest with assertType() would be nice to verify what it's actually resolved to.

@ondrejmirtes ondrejmirtes merged commit 25203fd into phpstan:1.8.x Oct 11, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes ondrejmirtes mentioned this pull request Oct 11, 2022
Closed
@mvorisek
Copy link
Contributor

Thank you!

@rvanvelzen rvanvelzen deleted the bug-7839 branch October 11, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvanvelzen @ondrejmirtes @mvorisek