Skip to content

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Oct 11, 2022

this makes more sense to me, having this in the array traits felt a bit weird already in #1811

Also fixes the new iterable methods via IterableType and ObjectType

@herndlm herndlm force-pushed the cleanup-traits branch 2 times, most recently from 5ff3b4f to f5f37c9 Compare October 11, 2022 15:18
@herndlm
Copy link
Contributor Author

herndlm commented Oct 11, 2022

needed a couple more nudges than I thought because of the usage of JustNullableTypeTrait
UPDATE: I think I was misusing JustNullableTypeTrait by using other traits inside it which is a bit weird maybe and could block future types somehow potentially. I moved use statements out of it and rather use NonArrayTypeTrait and NonIterableTypeTrait explicitly which feels "safer". The couple of lines saved was not worth it.

Now I'm happy with this :)

@herndlm herndlm marked this pull request as draft October 11, 2022 15:41
@herndlm herndlm marked this pull request as ready for review October 11, 2022 15:53
@herndlm
Copy link
Contributor Author

herndlm commented Oct 12, 2022

fyi the failure is unrelated, there seems to be a new baseline update needed for composer on 1.9.x

@ondrejmirtes ondrejmirtes merged commit 67a1a7a into phpstan:1.9.x Oct 12, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@herndlm herndlm deleted the cleanup-traits branch October 12, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants