Add Type::isConstantArray()
#1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
is-constant-array
branch
from
90be120 to
abaf186
Compare
|
failures seem to be unrelated packagist timeouts, I'll leave this alone for now.. |
staabm
reviewed
Oct 12, 2022
herndlm
force-pushed
the
is-constant-array
branch
from
abaf186 to
27864b0
Compare
herndlm
force-pushed
the
is-constant-array
branch
from
27864b0 to
b0c875f
Compare
ondrejmirtes
requested changes
Oct 12, 2022
herndlm
force-pushed
the
is-constant-array
branch
from
9ae162d to
4a5a148
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not get rid of many
instanceoftype checks yet unfortunately though. in order to achieve that more methods on type are needed. I hope I can do a bit more soon, but there are definitely limits to what makes sense right now.