Add support for mb_convert_case() and mb_convert_kana() #1866
+91
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
commented
Oct 17, 2022
| } | ||
|
|
||
| $constantStrings = array_map(fn ($type) => $type->getValue(), TypeUtils::getConstantStrings($argType)); | ||
| if (count($constantStrings) > 0 && mb_check_encoding($constantStrings, 'UTF-8')) { |
There was a problem hiding this comment.
mb_check_encoding() seems to accept arrays in PHP 7.2.0 and above.
ondrejmirtes
changed the title
|
Thank you! |
|
@zonuexe it seems this one requires a fix for the test-expectations in the php 7.2 https://github.com/phpstan/phpstan-src/actions/runs/3269863209/jobs/5377858799 |
|
Fixed it the easiest way: 0a4c52c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
mb_convert_case()andmb_convert_kana()withStrCaseFunctionsReturnTypeExtension.Strictly speaking, Japanese kana characters are not casing, but many of the treatments are common.