refactor pow() return type extension to re-use BinaryOp\Pow #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Oct 23, 2022
Comment on lines
+1134
to
+1135
| !$leftType instanceof NeverType && | ||
| !$rightType instanceof NeverType && |
There was a problem hiding this comment.
I added these 2 NeverType guard conditions, to not regress existing integer-range-math tests in
phpstan-src/tests/PHPStan/Analyser/data/math.php
Lines 157 to 158 in ff0d36e
|
Thank you! |
|
I think it solve phpstan/phpstan#2009 @ondrejmirtes @staabm, no ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to bring both implementations in sync, and therefore on feature parity.
next step, in a followup PR, will be to add IntegerRangeType support to
pow