Improve non-array specification for recently cleaned-up array functions #1907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array_fill_keys: https://3v4l.org/8ik8V
array_flip: https://3v4l.org/jBASO
array_keys: https://3v4l.org/TYWrU
array_values: https://3v4l.org/89UDN
I was lazy with the pre PHP 8 checks and just wrapped them in conditionals like I did it with array_search. should the test files be split maybe to assert this for PHP < 8 as well? or not worth the hassle? hmm. we could maybe also move them all out to 2 test files only. e.g. non-array-array-functions.php and non-array-array-functions-php8.php or so