refactor arrow function scope logic to make it consistent with anonym… #1935
Conversation
rajyan
force-pushed
the
arrow-function-scope-refactor
branch
from
38f01d3 to
a59c5f9
Compare
|
My thinking is that, |
|
Does this change anything in type inference? Should there be a test? |
| continue; | ||
| } | ||
|
|
||
| $conditionalExpressions[$conditionalExprString] = $newHolders; |
There was a problem hiding this comment.
This line was never called because of the above foreach in line 3028.
| } | ||
| } | ||
|
|
||
| $newHolders[] = $holder; |
There was a problem hiding this comment.
It is always newHolders === holders because of the continue 3
| foreach ($parameterVariableExpressions as $expr) { | ||
| $scope = $scope->invalidateExpression($expr, true); | ||
| } |
There was a problem hiding this comment.
This line is handled in assignVariable's invalidateExpression
From the investigations above, I believe using |
|
Alright, great, thank you :) |
…ous functions
Refactor anonymous function scope to use invalidate logic of assignVariable instead of the duplication.
This makes the logic consistent with
#1934