Skip to content

Add noreturn as PseudoTypeClass #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2022
Merged

Add noreturn as PseudoTypeClass #1937

merged 2 commits into from
Oct 30, 2022

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Oct 29, 2022

ondrejmirtes
ondrejmirtes requested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. NodeScopeResolverTest that shows NeverType vs namespaced class ObjectType is sufficient.

@ondrejmirtes ondrejmirtes merged commit 18b242c into phpstan:1.9.x Oct 30, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@zonuexe zonuexe deleted the fix/never-type-as-possible-defined branch October 30, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

noreturn not allowed in @return when class is defined
2 participants
@zonuexe @ondrejmirtes